Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Log setup/cleanup/upgrade actions
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-common/distro-rpm/log_setup_event.py
Line 61: self.execute(
Line 62: (
Line 63: osetupcons.FileLocations.OVIRT_ENGINE_LOG_SETUP_EVENT,
Line 64: '--notes=Start of otopi action ' +
Line 65: self.environment[osetupcons.CoreEnv.ACTION],
Best to use templates and not concat...
either:
'--notes=Start of otopi action %s' % self.environment[
osetupcons.CoreEnv.ACTION
]
or:
'--notes=Start of otopi action {action}'.format(
action=self.environment[osetupcons.CoreEnv.ACTION],
)
as this is internal and not localization, the 1st method is shorter and ok.
I would have dropped the bla bla... just:
'--notes=START-%s' % self.environment[
osetupcons.CoreEnv.ACTION
]
Line 66: ),
Line 67: )
Line 68:
Line 69: @plugin.event(
--
To view, visit http://gerrit.ovirt.org/15863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
