Emily Zhang has posted comments on this change.

Change subject: [WIP] engine:Trusted Compute Pools - Open Attestation 
integration with oVirt engine proposal
......................................................................


Patch Set 14: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 76:     private boolean initTrustedService() {
Line 77:         List <String> hosts = new ArrayList<String> ();
Line 78: 
Line 79:         if (getVds().getStatus() != VDSStatus.NonOperational
Line 80:                 || getVds().getNonOperationalReason() != 
NonOperationalReason.UNTRUSTED) {
when engine restart, vds status is NonOperational with UNINITIALIZED reason, 
and reason of untrusted is set in InitVdsUp process.
So the condition is like this:
if (getVds().getStatus() != VDSStatus.NonOperational
                                        || getVds().getNonOperationalReason() 
!= NonOperationalReason.UNINITIALIZED).
How do you think?
Line 81:             return true;
Line 82:         }
Line 83: 
Line 84:         hosts.add(getVds().getHostName());


-- 
To view, visit http://gerrit.ovirt.org/14605
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com>
Gerrit-Reviewer: Gang Wei <gang....@intel.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to