mooli tayer has posted comments on this change. Change subject: Notification service should send a notification when Database is down. ......................................................................
Patch Set 2: I fixed Yair's 2nd comment although I originally did it because my IDE warned about it (http://www.hpenterprisesecurity.com/vulncat/en/vulncat/cpp/poor_style_redundant_initialization.html) If you mean line 236 this is a java 7 enhancement: http://docs.oracle.com/javase/7/docs/technotes/guides/language/type-inference-generic-instance-creation.html Please advise. -- To view, visit http://gerrit.ovirt.org/15768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0d36b6140846bf98a33064cc69a9a398a8d4128 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
