Yair Zaslavsky has posted comments on this change.
Change subject: Notification service should send a notification when Database
is down.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
Line 83: }
Line 84: initMethodMapper();
Line 85: failedQueriesEventSender =
Line 86:
methodsMapper.getMethod(EventNotificationMethods.EMAIL);
Line 87:
trailing whitespace, please remove.
Line 88: }
Line 89:
Line 90: private int getNonNegativeIntegerProperty(final String name)
throws NotificationServiceException {
Line 91: // Get the text of the property:
Line 258: dbUser =
getUserByUserId(eventSubscriber.getsubscriber_id());
Line 259: if (dbUser != null) {
Line 260: EventSender method =
Line 261:
methodsMapper.getMethod(EventNotificationMethods.forValue(eventSubscriber.getmethod_id()));
Line 262: EventSenderResult sendResult;
why did you change this? I don't think it's needed (i.e - keep the original
code).
Line 263: try {
Line 264: sendResult = method.send(eventSubscriber,
dbUser.getemail());
Line 265: } catch (Exception e) {
Line 266: log.error("Failed to dispatch message", e);
--
To view, visit http://gerrit.ovirt.org/15768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0d36b6140846bf98a33064cc69a9a398a8d4128
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
