Alon Bar-Lev has posted comments on this change.
Change subject: Log setup events
......................................................................
Patch Set 1: (1 inline comment)
please also add this as a plugin to the new installation at packaging/setup.
I also wounder... what if we runt his at rpm %pre and %post? won't it have the
same effect?
....................................................
File packaging/fedora/setup/ovirt-engine-log-setup-event.sh.in
Line 47: --notes=*)
Line 48: notes="${v}"
Line 49: ;;
Line 50: --help)
Line 51: usage
I am almost sure that the custom is to return success at --help
Line 52: ;;
Line 53: *)
Line 54: die "Invalid option '${x}'"
Line 55: ;;
--
To view, visit http://gerrit.ovirt.org/15863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
