Sandro Bonazzola has posted comments on this change. Change subject: Log setup events ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/fedora/setup/ovirt-engine-log-setup-event.sh.in Line 59: ( Line 60: echo SETUP-EVENT-BEGIN Line 61: echo DATE: $(date +'%Y-%m-%d %H:%M:%S') Line 62: echo NOTES: ${notes} Line 63: rpm -qa | sort | while read package; do I would have used rpm -qa --last for having also the timestamps of the installation of the packages. Line 64: echo PACKAGE: ${package} Line 65: done Line 66: echo SETUP-EVENT-END -- To view, visit http://gerrit.ovirt.org/15863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches