Alona Kaplan has posted comments on this change.

Change subject: webadmin: Added linking from Provider to Network
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java
Line 64:     }
Line 65: 
Line 66:     @Override
Line 67:     public void setNetworkClickHandler(FieldUpdater<Network, String> 
fieldUpdater) {
Line 68:         nameColumn.setFieldUpdater(fieldUpdater);
Why is it different from the previous ("Added linking from Network to 
Provider") patch?
Why did you need there to clean the selection 
(getTable().getSelectionModel().clear();) and here not?
Line 69:     }
Line 70: 


-- 
To view, visit http://gerrit.ovirt.org/15524
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I326dbf7ae46d2e07a3472581af36b9dd57407862
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to