Lior Vernia has posted comments on this change.
Change subject: webadmin: Added linking from Provider to Network
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java
Line 64: }
Line 65:
Line 66: @Override
Line 67: public void setNetworkClickHandler(FieldUpdater<Network, String>
fieldUpdater) {
Line 68: nameColumn.setFieldUpdater(fieldUpdater);
Basically this is because there the link is pressed within a main tab and here
within a subtab. What happened there without the additional line, is if there
was no item selected in the main tab prior to clicking on the link, a null
pointer exception was thrown in a check for the active details model.
I inferred (though I didn't completely understand the flow) that the click
would still get to the row itself which caused it to be selected behind the
scenes (probably because the link is a cell within the row cell, so by the time
it gets to the link it has had to have gone through the row). However, no
subtabs were displayed (probably because the click on the link is captured
before the click on the row is handled, but this is a good thing as the subtabs
don't "flash"), so the combination of a selected item but no subtabs caused
trouble.
It was also possible to fix it by adding a null check in
AbstractMainTabWithDetailsPresenter, but I didn't know what else that could
break.
Line 69: }
Line 70:
--
To view, visit http://gerrit.ovirt.org/15524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I326dbf7ae46d2e07a3472581af36b9dd57407862
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
