Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Suspicious reference comparison of Boolean values ......................................................................
findbugs: Suspicious reference comparison of Boolean values commit dcc771b2ad21bea0caecaef79cf26daaa8ecc229 fix reference comparison of Boolean values. I GWT debugging we are getting NPE because the new comparison of consoleAddressPartiallyOverridden null value to false, hence not setting it to false. This patch add default value to false and change the isConsoleAddressPartiallyOverridden() to return false instead of null Change-Id: I81405b5484dcfcaa4e7f90279e076cad5f085581 Signed-off-by: Shahar Havivi <shav...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81405b5484dcfcaa4e7f90279e076cad5f085581 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
