Lior Vernia has posted comments on this change. Change subject: findbugs: Suspicious reference comparison of Boolean values ......................................................................
Patch Set 10: Shahar, I'm GWT-debugging and the change in ClusterGeneralModel seems to cause a null pointer exception. I'm inferring that setConsoleAddressPartiallyOverridden() is called with a non-null value, but because the comparison turns the original null value of consoleAddressPartiallyOverridden to false, the value isn't set, and later isConsoleAddressPartiallyOverridden() returns null. This can be solved either by reverting this patch or changing the getter to return false if the property is null. -- To view, visit http://gerrit.ovirt.org/15325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I210767bb1e273caa421bf3da1b1608a7facb6621 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
