Alona Kaplan has posted comments on this change. Change subject: webadmin: Added functionality to Add Provider Network popup ......................................................................
Patch Set 14: (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java Line 314: network.setName((String) getName().getEntity()); Line 315: network.setStp((Boolean) getIsStpEnabled().getEntity()); Line 316: network.setDescription((String) getDescription().getEntity()); Line 317: network.setVmNetwork((Boolean) getIsVmNetwork().getEntity()); Line 318: network.setLabel((String) getNetworkLabel().getEntity()); Where is the view of this label? Do you want it to be visible in all the NetworkModels? Line 319: Line 320: network.setMtu(0); Line 321: if (getMtu().getEntity() != null) Line 322: { -- To view, visit http://gerrit.ovirt.org/11436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2659239cf6b76299905a3a99e2d2ca48c7aeaf45 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches