Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added functionality to Add Provider Network popup
......................................................................
Patch Set 14: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
Line 94: }
Line 95:
Line 96: @Override
Line 97: protected void executeSave() {
Line 98: executeParticularSave(VdcActionType.AddNetwork);
I think it is more readable to add getSaveActionType() method instead of
executeParticularSave. It is hard to understand what is the differencd between
executeSave and executeParticularSave.
Line 99: }
Line 100:
Line 101: protected void executeParticularSave(VdcActionType
particularSave) {
Line 102: // New network
--
To view, visit http://gerrit.ovirt.org/11436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2659239cf6b76299905a3a99e2d2ca48c7aeaf45
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
