Yair Zaslavsky has posted comments on this change. Change subject: 11. core: SPMAsyncTask - change from associatedEntities + single type to map ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/dbscripts/async_tasks_sp.sql Line 99: Line 100: RETURNS VOID Line 101: AS $procedure$ Line 102: BEGIN Line 103: IF NOT EXISTS (SELECT 1 from async_tasks_entities where async_task_id = v_task_id and entity_id = v_entity_id) THEN Please elaborate - Do you want me to try to get the list of entities associated with the tasks, and if the entity i want to add exists in the list that i retrieved from db, not add them? Why to do the redundant get? Line 104: INSERT INTO async_tasks_entities (async_task_id,entity_id,entity_type) VALUES (v_task_id, v_entity_id, v_entity_type); Line 105: END IF; Line 106: END; $procedure$ Line 107: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/15567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8826761f833944e8a4d9159bf91863381cfb1f79 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
