Allon Mureinik has posted comments on this change. Change subject: 11. core: SPMAsyncTask - change from associatedEntities + single type to map ......................................................................
Patch Set 6: I would prefer that you didn't submit this (3 inline comments) .................................................... File backend/manager/dbscripts/async_tasks_sp.sql Line 99: Line 100: RETURNS VOID Line 101: AS $procedure$ Line 102: BEGIN Line 103: IF NOT EXISTS (SELECT 1 from async_tasks_entities where async_task_id = v_task_id and entity_id = v_entity_id) THEN why do you need this validation in the DB side and not in the client (DAO) side? Line 104: INSERT INTO async_tasks_entities (async_task_id,entity_id,entity_type) VALUES (v_task_id, v_entity_id, v_entity_type); Line 105: END IF; Line 106: END; $procedure$ Line 107: LANGUAGE plpgsql; Line 177: Line 178: Create or replace FUNCTION GetAsyncTasksByEntityId(v_entity_id UUID) RETURNS SETOF async_tasks Line 179: AS $procedure$ Line 180: BEGIN Line 181: RETURN QUERY SELECT async_tasks.* this has nothing to do with this patch - please remove it from here, and add in the correct patch Line 182: FROM async_tasks JOIN async_tasks_entities ON async_task_id = task_id Line 183: WHERE entity_id = v_entity_id; Line 184: Line 185: END; $procedure$ .................................................... Commit Message Line 4: Commit: Ravi Nori <rn...@redhat.com> Line 5: CommitDate: 2013-06-15 23:01:53 -0400 Line 6: Line 7: 11. core: SPMAsyncTask - change from associatedEntities + single type to map Line 8: description? explanation? feature page link? Line 9: Change-Id: I8826761f833944e8a4d9159bf91863381cfb1f79 -- To view, visit http://gerrit.ovirt.org/15567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8826761f833944e8a4d9159bf91863381cfb1f79 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
