Ravi Nori has posted comments on this change.
Change subject: 15. core : Handle incomplete tasks on server restart
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 698: if
(!_tasks.containsKey(creationInfo.getVdsmTaskId())) {
Line 699: try {
Line 700: SPMAsyncTask task;
Line 701: if
(isPartiallyCompletedCommandTask(creationInfo.getVdsmTaskId())) {
Line 702: AsyncTasks asyncTaskInDb =
getPartiallyCompletedTaskFromList(creationInfo.getVdsmTaskId());
Here we handle tasks of a partially submitted command that have been submitted
to vdsm. So they have a vdsm id. The tasks that don't have have vdsm id are
handled in handleTaskOfCommandWithEmptyVdsmId
Line 703: task =
AsyncTaskFactory.Construct(creationInfo, asyncTaskInDb);
Line 704: if (task.getEntitiesMap() == null) {
Line 705: task.setEntitiesMap(new
HashMap<Guid, VdcObjectType>());
Line 706: }
--
To view, visit http://gerrit.ovirt.org/15630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a979d816d9ec8cf25119a33742c8e6af4ff42a8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
