Allon Mureinik has posted comments on this change.
Change subject: 16. core : Handle incomplete tasks on server restart
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(1 inline comment)
minor implementation issue - see inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 236: Guid rootCommandId = task.getRootCommandId();
Line 237: if
(!rootCommandIdToCommandsMap.containsKey(rootCommandId)) {
Line 238: rootCommandIdToCommandsMap.put(rootCommandId, new
ArrayList<AsyncTasks>());
Line 239: }
Line 240: MultiValueMapUtils.addToMap(rootCommandId, task,
rootCommandIdToCommandsMap);
You misunderstood the comment - the purpose of MultiValueMapUtils is to save
you the hassle of adding an empty ArrayList.
The above if is redundant.
Line 241: }
Line 242: return rootCommandIdToCommandsMap;
Line 243: }
Line 244:
--
To view, visit http://gerrit.ovirt.org/15630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a979d816d9ec8cf25119a33742c8e6af4ff42a8
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
