Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Gluster Sync job event log corrected
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 537: @SuppressWarnings("serial")
Line 538: private void removeDeletedOptions(GlusterVolumeEntity
fetchedVolume,
Line 539: Collection<GlusterVolumeOptionEntity> existingOptions) {
Line 540: List<Guid> idsToRemove = new ArrayList<Guid>();
Line 541: for (final GlusterVolumeOptionEntity existingOption :
existingOptions) {
How long is this list?
These logs should be done in a single transaction.
I would suggest to consult emesika about this.
Line 542: if (fetchedVolume.getOption(existingOption.getKey()) ==
null) {
Line 543: idsToRemove.add(existingOption.getId());
Line 544: log.infoFormat("Detected option {0} reset on volume
{1}. Removing it from engine DB as well.",
Line 545: existingOption.getKey(),
--
To view, visit http://gerrit.ovirt.org/15172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ed05a8ef5faec8202b79fe0037482d956f3fed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
