Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Gluster Sync job event log corrected
......................................................................
Patch Set 3: Verified
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 642: }
Line 643: }
Line 644:
Line 645: private void updateExistingOptions(final GlusterVolumeEntity
volume, Collection<GlusterVolumeOptionEntity> entities) {
Line 646: getOptionDao().updateAll("UpdateGlusterVolumeOption",
entities);
This would not be required as the variable volume consists the old details and
update has happened with entities instance variable.
In log we are old values from volume and new from the entities (which is new
one).
Verified the same.
Line 647: for (final GlusterVolumeOptionEntity entity : entities) {
Line 648: logUtil.logAuditMessage(volume.getClusterId(), volume,
null,
Line 649:
AuditLogType.GLUSTER_VOLUME_OPTION_CHANGED_FROM_CLI,
Line 650: new HashMap<String, String>() {
--
To view, visit http://gerrit.ovirt.org/15172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ed05a8ef5faec8202b79fe0037482d956f3fed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
