Federico Simoncelli has posted comments on this change.

Change subject: core: add the openstack dependency
......................................................................


Patch Set 13: (3 inline comments)

....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 144: select 
fn_db_add_config_value('GlusterVolumeOptionOwnerUserVirtValue','36','general');
Line 145: select 
fn_db_add_config_value('GlusterVolumeOptionOwnerGroupVirtValue','36','general');
Line 146: 
Line 147: -- OpenStack related
Line 148: -- KeystoneAuthUrl (version 2.0): http://keystone-server:35357
Done
Line 149: select fn_db_add_config_value('KeystoneAuthUrl', '', 'general');
Line 150: 
Line 151: select 
fn_db_add_config_value('GuestToolsSetupIsoPrefix','RHEV-toolsSetup_','general');
Line 152: select fn_db_add_config_value('HardwareInfoEnabled','false','3.0');


Line 145: select 
fn_db_add_config_value('GlusterVolumeOptionOwnerGroupVirtValue','36','general');
Line 146: 
Line 147: -- OpenStack related
Line 148: -- KeystoneAuthUrl (version 2.0): http://keystone-server:35357
Line 149: select fn_db_add_config_value('KeystoneAuthUrl', '', 'general');
I'd rather not set a (possibly) valid value as default.
Line 150: 
Line 151: select 
fn_db_add_config_value('GuestToolsSetupIsoPrefix','RHEV-toolsSetup_','general');
Line 152: select fn_db_add_config_value('HardwareInfoEnabled','false','3.0');
Line 153: select fn_db_add_config_value('HardwareInfoEnabled','false','3.1');


....................................................
File 
backend/manager/dependencies/src/main/modules/com/woorea/openstack/sdk/main/module.xml
Line 1: <?xml version="1.0" encoding="UTF-8"?>
Line 2: 
Line 3: <!-- This module contains all the dependencies that are used by serveral
Line 4:      engine components and that are not available as builtin modules in
Line 5:      JBoss 7: -->
Done
Line 6: 
Line 7: <module xmlns="urn:jboss:module:1.0" name="com.woorea.openstack.sdk">
Line 8:    <resources>
Line 9:      <resource-root path="glance-client.jar"/>


-- 
To view, visit http://gerrit.ovirt.org/13434
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib516b48ba9c7e3b9bbc657fe970361a484221e88
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to