Mike Kolesnik has posted comments on this change.

Change subject: core: add the openstack dependency
......................................................................


Patch Set 13: (2 inline comments)

Probably should add entries in 
packaging/etc/engine-config/engine-config.properties to allow configuring this 
via config tool..

You can see the other keys there, it's pretty straightforward..

....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 144: select 
fn_db_add_config_value('GlusterVolumeOptionOwnerUserVirtValue','36','general');
Line 145: select 
fn_db_add_config_value('GlusterVolumeOptionOwnerGroupVirtValue','36','general');
Line 146: 
Line 147: -- OpenStack related
Line 148: -- KeystoneAuthUrl (version 2.0): http://keystone-server:35357
Not sure that the comment is needed..
Line 149: select fn_db_add_config_value('KeystoneAuthUrl', '', 'general');
Line 150: 
Line 151: select 
fn_db_add_config_value('GuestToolsSetupIsoPrefix','RHEV-toolsSetup_','general');
Line 152: select fn_db_add_config_value('HardwareInfoEnabled','false','3.0');


Line 145: select 
fn_db_add_config_value('GlusterVolumeOptionOwnerGroupVirtValue','36','general');
Line 146: 
Line 147: -- OpenStack related
Line 148: -- KeystoneAuthUrl (version 2.0): http://keystone-server:35357
Line 149: select fn_db_add_config_value('KeystoneAuthUrl', '', 'general');
Perhaps a sensible default is http://localhost:35357 ?
Line 150: 
Line 151: select 
fn_db_add_config_value('GuestToolsSetupIsoPrefix','RHEV-toolsSetup_','general');
Line 152: select fn_db_add_config_value('HardwareInfoEnabled','false','3.0');
Line 153: select fn_db_add_config_value('HardwareInfoEnabled','false','3.1');


-- 
To view, visit http://gerrit.ovirt.org/13434
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib516b48ba9c7e3b9bbc657fe970361a484221e88
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to