Alon Bar-Lev has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch ......................................................................
Patch Set 3: (1 inline comment) .................................................... Commit Message Line 3: AuthorDate: 2013-06-13 13:39:30 -0400 Line 4: Commit: Alexander Wels <aw...@redhat.com> Line 5: CommitDate: 2013-06-13 15:13:54 -0400 Line 6: Line 7: userportal,webadmin: fix comment from branding patch BTW: general comment, the patch subject should be functional and not internal description. userportal,webadmin: update branding manager userportal,webadmin: fix comment from branding patch Means almost nothing for future people who look at the history. expose branding manager to backend fix security issue at branding path Are better descriptors. Line 8: Line 9: - Fixed BrandingServlet getFullPath according to branding patch Line 10: comment (pass root in as parameter). Line 11: - Fixed potential double forward slash. -- To view, visit http://gerrit.ovirt.org/15702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fad1cda014713724f294fe8454fb5f36870c137 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
