Yair Zaslavsky has posted comments on this change. Change subject: [WIP] Introduce new directory interface ......................................................................
Patch Set 1: (4 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/Directory.java Line 26: * @param name the name of the user Line 27: * @return the user corresponding to the given name or Line 28: * <code>null</code> if no such user can be found Line 29: */ Line 30: DirectoryUser findUserByName(String name); I think Alon's idea is worth considering. Line 31: Line 32: /** Line 33: * Retrieves an user from the directory given its identifier. Note that this Line 34: * identifier is the one assigned by the engine to the user, not the one Line 50: * with no particular order, note that the returned set may contain less Line 51: * elements than the given set of identifiers and that it may be in a Line 52: * different order Line 53: */ Line 54: Set<DirectoryUser> findUsersById(Set<Guid> ids); +1. Juan, you can look for example at what we did with the BusinessEntity intrerface. We also had the same dilemma back then about types of IDs of entities, and we did not want to limit ourselves. Line 55: Line 56: /** Line 57: * Retrieves a group from the directory given its identifier. Note that this Line 58: * identifier is the one assigned by the engine to the group, not the one Line 63: * @param id the identifier of the group Line 64: * @return the group corresponding to the given identifier or Line 65: * <code>null</code> if no such group can be found Line 66: */ Line 67: DirectoryGroup findGroupById(Guid id); So to be consistent with alon's idea -findGroup which expects atribute and attribute-value. Line 68: Line 69: /** Line 70: * Search the directory looking for users that match the given search query. Line 71: * Line 80: * Line 81: * @param query the query Line 82: * @return a list containing the groups that match the given query Line 83: */ Line 84: Set<DirectoryGroup> findGroupsByQuery(String query); Query is used by the search mechanism, which generates some ad query. I hope this answers. Any alternate suggestion, now that you know the scope? -- To view, visit http://gerrit.ovirt.org/15596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84a0c9d6553d81cdbbe224972696f169cca90d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
