Omer Frenkel has posted comments on this change. Change subject: core: add get*Type to template DAO ......................................................................
Patch Set 13: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java Line 32: public VmTemplate get(Guid id) { Line 33: return get(id, null, false); Line 34: } Line 35: Line 36: @Override but this method is used to actually get an object from the db, but to be sure which its implementing a specific interface Line 37: public InstanceType getInstanceType(Guid id) { Line 38: VmTemplate result = get(id); Line 39: if (result != null && result.getTemplateType() != TemplateType.INSTANCE_TYPE) { Line 40: result = null; -- To view, visit http://gerrit.ovirt.org/12280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9f0eef1e61b51cc941b8dd9403f5733a69f9dfc Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches