Roy Golan has posted comments on this change.

Change subject: core: add get*Type to template DAO
......................................................................


Patch Set 16: Looks good to me, approved

(1 inline comment)

minor javadoc comment

....................................................
File 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDAOTest.java
Line 81:         assertEquals(EXISTING_INSTANCE_TYPE_ID, result.getId());
Line 82:     }
Line 83: 
Line 84:     /**
Line 85:      * Ensures that the template returned is instance type.
copy paste...
Line 86:      */
Line 87:     @Test
Line 88:     public void testGetImageType() {
Line 89:         ImageType result = dao.getImageType(EXISTING_IMAGE_TYPE_ID);


-- 
To view, visit http://gerrit.ovirt.org/12280
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9f0eef1e61b51cc941b8dd9403f5733a69f9dfc
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to