Yair Zaslavsky has posted comments on this change. Change subject: core: Fail tasks that dont have Vdsm Id ......................................................................
Patch Set 23: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java Line 21: * Holds the ids of the async task place holders in the database. Line 22: * On server restart this list used to clean up and fail all the tasks Line 23: * that have place holders but don't have a vdsm task id. Line 24: */ Line 25: private ArrayList<Guid> asyncTaskIdList = new ArrayList<Guid>(); Ravi, 1. what do you think about changing this to 2. taskPlaceHoldersIdsList? 2. Can you please explain what is taskIdList in the comments (yes, I know it existed before, but now that we added another list, I think it will improve code readability) Line 26: private ArrayList<Guid> taskIdList = new ArrayList<Guid>(); Line 27: private final ArrayList<Guid> _internalIdList = new ArrayList<Guid>(); Line 28: private boolean _endActionTryAgain = true; Line 29: private final ArrayList<String> _executeFailedMessages = new ArrayList<String>(); -- To view, visit http://gerrit.ovirt.org/14368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110c483842027d1596f64dd8c3f635d62924a93f Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
