Alex Lourie has posted comments on this change.

Change subject: [WIP] core: 3.1 backup fix tool.
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File backend/manager/tools/dbutils/plpgsql.sql
Line 1: CREATE OR REPLACE FUNCTION make_plpgsql()
I suggest to drop function if exists before this. It happened before that we 
add a function, then we update it changing its signature and then "CREATE OR 
REPLACE" fails.
Line 2: RETURNS VOID
Line 3: LANGUAGE SQL
Line 4: AS $$
Line 5: CREATE LANGUAGE plpgsql;


-- 
To view, visit http://gerrit.ovirt.org/15068
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id17f718d5acf7a4df00092875d308f52e6dd7e3f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to