Kiril Nesenko has posted comments on this change.
Change subject: [WIP] core: 3.1 backup fix tool.
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File backend/manager/tools/dbutils/backupfixtool.sh
Line 49: exit 1
Line 50: fi
Line 51: }
Line 52:
Line 53: if [[ ! -n "${FILE}" ]]; then
if [ -z "${FILE}" ]; then
Line 54: usage
Line 55: exit 1
Line 56: fi
Line 57:
Line 59:
Line 60: echo "validating the ${FILE} file type..."
Line 61: if file "${FILE}" | grep 'tar'; then
Line 62: echo "Extracting the restore.sql file ..."
Line 63: tar -xf "$FILE" restore.sql > /dev/null
"${FILE}"
Line 64: if [ $? -ne 0 ]; then
Line 65: echo "Failed to extract restore.sql file from ${FILE}."
Line 66: exit 1
Line 67: fi
Line 71: sed -i '/^CREATE SCHEMA/d' restore.sql
Line 72: sed -i '/^ALTER TABLE ONLY public\./d' restore.sql
Line 73: sed -i '/^ALTER FUNCTION public\.uuid_/d' restore.sql
Line 74: sed -i '/^CREATE PROCEDURAL LANGUAGE plpgsql/d' restore.sql
Line 75: sed -i 's/^CREATE FUNCTION uuid_/CREATE OR REPLACE FUNCTION
uuid_/g' restore.sql
Please use sed -e and replace all of these sed commands
Line 76: echo "replacing the restore.sql file in original tar file..."
Line 77: tar -uvf ${FILE} restore.sql
Line 78: if [ $? -ne 0 ]; then
Line 79: echo "Failed to replace fixed restore.sql file in ${FILE}."
Line 72: sed -i '/^ALTER TABLE ONLY public\./d' restore.sql
Line 73: sed -i '/^ALTER FUNCTION public\.uuid_/d' restore.sql
Line 74: sed -i '/^CREATE PROCEDURAL LANGUAGE plpgsql/d' restore.sql
Line 75: sed -i 's/^CREATE FUNCTION uuid_/CREATE OR REPLACE FUNCTION
uuid_/g' restore.sql
Line 76: echo "replacing the restore.sql file in original tar file..."
Replacing
Line 77: tar -uvf ${FILE} restore.sql
Line 78: if [ $? -ne 0 ]; then
Line 79: echo "Failed to replace fixed restore.sql file in ${FILE}."
Line 80: exit 2
Line 73: sed -i '/^ALTER FUNCTION public\.uuid_/d' restore.sql
Line 74: sed -i '/^CREATE PROCEDURAL LANGUAGE plpgsql/d' restore.sql
Line 75: sed -i 's/^CREATE FUNCTION uuid_/CREATE OR REPLACE FUNCTION
uuid_/g' restore.sql
Line 76: echo "replacing the restore.sql file in original tar file..."
Line 77: tar -uvf ${FILE} restore.sql
use quotes "${FILE}"
Line 78: if [ $? -ne 0 ]; then
Line 79: echo "Failed to replace fixed restore.sql file in ${FILE}."
Line 80: exit 2
Line 81: fi
--
To view, visit http://gerrit.ovirt.org/15068
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id17f718d5acf7a4df00092875d308f52e6dd7e3f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
