Yair Zaslavsky has posted comments on this change.
Change subject: engine : Persist all async task place holders
......................................................................
Patch Set 21: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1337: }
Line 1338:
Line 1339: Map<String, Guid> taskKeyToTaskIdMap = new HashMap<>();
Line 1340:
Line 1341: public void persistAsyncTaskPlaceHolder(VdcActionType
parentCommand, String taskKey) {
As I suggested in another patch, we should consider having a version for
persistAsyncTaskPlaceHolder with one argument (parentCommand) which by default
uses a DEFAULT_TASK_KEY.
Same goes for getTaskIdForTaskKey - we should have a "getTaskIdMethod".
This is not mandatory, it's a suggestion.
Line 1342: if (!taskKeyToTaskIdMap.containsKey(taskKey)) {
Line 1343: taskKeyToTaskIdMap.put(taskKey,
persistAsyncTaskPlaceHolder(parentCommand));
Line 1344: }
Line 1345: }
--
To view, visit http://gerrit.ovirt.org/14819
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd4a377c3be055c48357881f731f7d1c01c3cb
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
