Yair Zaslavsky has posted comments on this change.

Change subject: engine : Persist all async task place holders
......................................................................


Patch Set 19: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1359: 
Line 1360:         try {
Line 1361:             AsyncTasks task = createAsyncTask(new 
AsyncTaskCreationInfo(), parentCommand);
Line 1362:             retValue = task.getTaskId();
Line 1363:             AsyncTaskUtils.addOrUpdateTaskInDB(task, null, 
EMPTY_GUID_ARRAY);
We will need to modify later on this, and provide a way to pass the map of 
entityId -> VdcObjectType (later on = next patches in the patchset that deal 
with fixing the task - entity association).
Line 1364:         } catch (RuntimeException ex) {
Line 1365:             log.errorFormat("Error during createAsyncTask for 
command: {0}. Exception {1}", this.getClass().getName(), ex);
Line 1366:         }
Line 1367: 


--
To view, visit http://gerrit.ovirt.org/14819
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd4a377c3be055c48357881f731f7d1c01c3cb
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to