Yair Zaslavsky has posted comments on this change.
Change subject: core : Fix for HibernateVm command
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
Line 167: }
Line 168:
Line 169: private VdcActionType getEndActionType(AsyncTasks dbAsyncTask) {
Line 170: VdcActionType commandType =
dbAsyncTask.getActionParameters().getCommandType();
Line 171: if (!VdcActionType.Unknown.equals(commandType)) {
It is possible.
I think that in the future we should revise and see if we need getCommandType
on params and the action_type of async_tasks - but currently the parameters are
the "parent command" parameters, so the command type is the parent command type.
Yes, i know it is supposed to be the same as "action_type" but I guess there is
a case where it's not the same.
Look at how the tasks are created at HibernateVmCommand.
Line 172: return commandType;
Line 173: }
Line 174: return dbAsyncTask.getaction_type();
Line 175: }
--
To view, visit http://gerrit.ovirt.org/15444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I529b7b4222e76f87e98b6807a89046a71fb8c938
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
