Yaniv Bronhaim has posted comments on this change.
Change subject: core : Fix for HibernateVm command
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
Line 167: }
Line 168:
Line 169: private VdcActionType getEndActionType(AsyncTasks dbAsyncTask) {
Line 170: VdcActionType commandType =
dbAsyncTask.getActionParameters().getCommandType();
Line 171: if (!VdcActionType.Unknown.equals(commandType)) {
shouldn't Unkown type refer to an error ? how is it possible to have cached
Unknown type .. if it's possible just explain as part of the commit message
please
Line 172: return commandType;
Line 173: }
Line 174: return dbAsyncTask.getaction_type();
Line 175: }
....................................................
Commit Message
Line 6:
Line 7: core : Fix for HibernateVm command
Line 8:
Line 9: HibernateVm command needed this fix in CommandAsyncTask for endAction
Line 10: to work
what does this fix do? why does it need it? please add more explanation ...
Line 11:
Line 12: Change-Id: I529b7b4222e76f87e98b6807a89046a71fb8c938
--
To view, visit http://gerrit.ovirt.org/15444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I529b7b4222e76f87e98b6807a89046a71fb8c938
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
