Moti Asayag has posted comments on this change.
Change subject: [WIP] core: RFE-Adding External Tasks Support
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1724: */
Line 1725: public Map<String, String> getJobMessageProperties() {
Line 1726: jobProperties = new HashMap<String, String>();
Line 1727: List<PermissionSubject> subjects =
getPermissionCheckSubjects();
Line 1728: if (jobProperties == null && subjects != null) {
in which case do you expect getPermissionCheckSubjects() to return null ?
i don't think it exists elsewhere in the code.
If a command doesn't require a permission on a certain entity, it should
override getPermissionCheckSubjects() with returning an empty list.
Line 1729: if (!subjects.isEmpty()) {
Line 1730: VdcObjectType entityType;
Line 1731: Guid entityId;
Line 1732: String value;
--
To view, visit http://gerrit.ovirt.org/15219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I622e2a92b0433edbbf45fc4ed4f352cb2d09872d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
