Yair Zaslavsky has posted comments on this change. Change subject: [WIP] core: RFE-Adding External Tasks Support ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 1725: public Map<String, String> getJobMessageProperties() { Line 1726: if (jobProperties == null) { Line 1727: jobProperties = new HashMap<String, String>(); Line 1728: List<PermissionSubject> subjects = getPermissionCheckSubjects(); Line 1729: if (subjects != null) { +1 On Sahina's id. Line 1730: if (!subjects.isEmpty()) { Line 1731: VdcObjectType entityType; Line 1732: Guid entityId; Line 1733: String value; -- To view, visit http://gerrit.ovirt.org/15219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I622e2a92b0433edbbf45fc4ed4f352cb2d09872d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches