Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: ignore: class name is the same as it super class
......................................................................
findbugs: ignore: class name is the same as it super class
findbugs complains that we are using the same class name as it super-class
currently PopupPanel and MenuBar are deeply coded in GWT.
we will ignore findbugs warning for now
findbugs reason:
Nm: Class names shouldn't shadow simple name of superclass
(NM_SAME_SIMPLE_NAME_AS_SUPERCLASS)
Change-Id: I17c5a70a75f41295cb2b68a1c86babadf1188974
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/15319/1
diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml
b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
index 0ccbcc4..20e078a 100644
--- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml
+++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
@@ -72,4 +72,28 @@
<Method name="hashCode"/>
<Bug code="DM"/>
</Match>
+
+ <!--
+ findbugs complains that we are using the same class name as it
super-class
+ currently MenuBar is deeply coded in GWT and we will ignore findbugs
warning for now
+
+ findbugs reason:
+ Nm: Class names shouldn't shadow simple name of superclass
(NM_SAME_SIMPLE_NAME_AS_SUPERCLASS)
+ -->
+ <Match>
+ <Class name="org.ovirt.engine.ui.common.widget.MenuBar" />
+ <Bug code="Nm"/>
+ </Match>
+
+ <!--
+ findbugs complains that we are using the same class name as it
super-class
+ currently PopupPanel is deeply coded in GWT and we will ignore
findbugs warning for now
+
+ findbugs reason:
+ Nm: Class names shouldn't shadow simple name of superclass
(NM_SAME_SIMPLE_NAME_AS_SUPERCLASS)
+ -->
+ <Match>
+ <Class name="org.ovirt.engine.ui.common.widget.PopupPanel" />
+ <Bug code="Nm"/>
+ </Match>
</FindBugsFilter>
--
To view, visit http://gerrit.ovirt.org/15319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17c5a70a75f41295cb2b68a1c86babadf1188974
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
