Martin Peřina has uploaded a new change for review. Change subject: core: Fix log event of proxy host ......................................................................
core: Fix log event of proxy host Adds logging of datacenter or cluster name when one host acts as a proxy for another one. Change-Id: Ieb071150cd9da75a8e5025862b650f3eddfaf10a Bug-Url: https://bugzilla.redhat.com/949469 Signed-off-by: Martin Perina <mper...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 29 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/15318/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java index c9449d7..32be34a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java @@ -127,7 +127,7 @@ _vds.getName()); } else { - logProxySelection(proxyHost.getName(), proxyOption.name(), _action.name()); + logProxySelection(proxyHost.getName(), proxyOption.createLogEntry(proxyHost), _action.name()); } return !NO_VDS.equals(proxyHostId); } @@ -335,5 +335,32 @@ return proxyHost; } private static Log log = LogFactory.getLog(FenceExecutor.class); - private enum PMProxyOptions {CLUSTER,DC;}; + private enum PMProxyOptions { + CLUSTER("cluster: "), + DC("data center: "); + + private final String logEntry; + + private PMProxyOptions(String logEntry) { + this.logEntry = logEntry; + } + + public String createLogEntry(VDS vds) { + StringBuilder sb = new StringBuilder(); + sb.append(logEntry); + switch (this) { + case CLUSTER: + sb.append(vds.getVdsGroupName()); + break; + + case DC: + sb.append(vds.getStoragePoolName()); + break; + + default: + break; + } + return sb.toString(); + } + }; } -- To view, visit http://gerrit.ovirt.org/15318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb071150cd9da75a8e5025862b650f3eddfaf10a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
