Moti Asayag has posted comments on this change.
Change subject: engine: Add support for vNICs in OpenstackNetwork
......................................................................
Patch Set 17: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/PortForCreate.java
Line 3: import org.codehaus.jackson.annotate.JsonProperty;
Line 4: import org.codehaus.jackson.map.annotate.JsonRootName;
Line 5:
Line 6: @JsonRootName("port")
Line 7: public class PortForCreate extends
org.openstack.quantum.model.PortForCreate {
I think the correct approach should be adding these properties to
org.openstack.quantum.model.PortForCreate rather maintaining a set of business
entities on engine side.
Line 8:
Line 9: @JsonProperty("mac_address")
Line 10: private String macAddress;
Line 11:
--
To view, visit http://gerrit.ovirt.org/11110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I465dee81c3348a3f49ff41a8983a8ba2c8d43fad
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
