Eli Mesika has uploaded a new change for review. Change subject: [WIP] core: Adding ClearExternalJobCommand ......................................................................
[WIP] core: Adding ClearExternalJobCommand Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91605498 Signed-off-by: Eli Mesika <emes...@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=872719 --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 50 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/15230/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java new file mode 100644 index 0000000..6807a29 --- /dev/null +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java @@ -0,0 +1,47 @@ +package org.ovirt.engine.core.bll; + +import java.util.List; + +import org.ovirt.engine.core.bll.utils.PermissionSubject; +import org.ovirt.engine.core.common.action.VdcActionParametersBase; +import org.ovirt.engine.core.common.job.Job; +import org.ovirt.engine.core.compat.Guid; +import org.ovirt.engine.core.dal.dbbroker.DbFacade; + +public class ClearExternalJobCommand <T extends VdcActionParametersBase> extends CommandBase<T>{ + + private Job job; + public ClearExternalJobCommand(T parameters) { + super(parameters); + } + + @Override + protected boolean canDoAction() { + boolean retValue = true; + if (getParameters().getJobId() != null) { + job = DbFacade.getInstance().getJobDao().get((Guid) getParameters().getJobId()); + if (job == null) { + retValue = false; + // TODO message + } + } + else { + retValue = false; + // TO DO message + } + return retValue; + } + + @Override + protected void executeCommand() { + job = DbFacade.getInstance().getJobDao().get((Guid) getParameters().getJobId()); + job.setAutoCleared(true); + DbFacade.getInstance().getJobDao().update(job); + + } + + @Override + public List<PermissionSubject> getPermissionCheckSubjects() { + return null; + } +} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java index 295b9f5..1c4d1e4 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java @@ -255,8 +255,9 @@ // External Tasks AddExternalJob(1800, ActionGroup.INJECT_EXTERNAL_TASKS, false, QuotaDependency.NONE), EndExternalJob(1801, ActionGroup.INJECT_EXTERNAL_TASKS, false, QuotaDependency.NONE), - AddExternalStep(1802, ActionGroup.INJECT_EXTERNAL_TASKS, false, QuotaDependency.NONE), - EndExternalStep(1803, ActionGroup.INJECT_EXTERNAL_TASKS, false, QuotaDependency.NONE); + ClearExternalJob(1802, ActionGroup.INJECT_EXTERNAL_TASKS, false, QuotaDependency.NONE), + AddExternalStep(1803, ActionGroup.INJECT_EXTERNAL_TASKS, false, QuotaDependency.NONE), + EndExternalStep(1804, ActionGroup.INJECT_EXTERNAL_TASKS, false, QuotaDependency.NONE); private int intValue; private ActionGroup actionGroup; -- To view, visit http://gerrit.ovirt.org/15230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91605498 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
