Oved Ourfali has posted comments on this change. Change subject: findbugs: ignore: use Sytesm.exit only in appropriate places ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) .................................................... Commit Message Line 6: Line 7: findbugs: ignore: use Sytesm.exit only in appropriate places Line 8: Line 9: findbugs warns about using System.exit() only in appropriate places. Line 10: in this case we do need to user exit(). s/user/use Line 11: look at exclude-filters.xml for more details Line 12: Line 13: Change-Id: Ia3bd1a72e5f7b78cbea10066d9e6490bee2ade86 -- To view, visit http://gerrit.ovirt.org/15273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3bd1a72e5f7b78cbea10066d9e6490bee2ade86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
