Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: ignore: use Sytesm.exit only in appropriate places
......................................................................
findbugs: ignore: use Sytesm.exit only in appropriate places
findbugs warns about using System.exit() only in appropriate places.
in this case we do need to user exit().
look at exclude-filters.xml for more details
Change-Id: Ia3bd1a72e5f7b78cbea10066d9e6490bee2ade86
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M backend/manager/modules/utils/exclude-filters.xml
M backend/manager/tools/exclude-filters.xml
2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/15273/1
diff --git a/backend/manager/modules/utils/exclude-filters.xml
b/backend/manager/modules/utils/exclude-filters.xml
index 6c66af0..2d80a22 100644
--- a/backend/manager/modules/utils/exclude-filters.xml
+++ b/backend/manager/modules/utils/exclude-filters.xml
@@ -21,4 +21,18 @@
<Method name="tearDown"/>
<Bug code="DE"/>
</Match>
+
+ <!--
+ findbugs warns about using System.exit() only in appropriate places.
+ in this case the tool KrbConfCreator exit with exit code 1 on parsing
+ arguments error
+
+ findbugs reason:
+ Dm: Method invokes System.exit(...) (DM_EXIT)
+ -->
+ <Match>
+ <Class name="org.ovirt.engine.core.utils.kerberos.KrbConfCreator" />
+ <Method name="parseOptions"/>
+ <Bug code="Dm"/>
+ </Match>
</FindBugsFilter>
diff --git a/backend/manager/tools/exclude-filters.xml
b/backend/manager/tools/exclude-filters.xml
index e1af053..b1d670a 100644
--- a/backend/manager/tools/exclude-filters.xml
+++ b/backend/manager/tools/exclude-filters.xml
@@ -26,4 +26,17 @@
<Method name="createConfigurationProvider"/>
<Bug code="RCN"/>
</Match>
+
+ <!--
+ findbugs warns about using System.exit() only in appropriate places.
+ in this case the service need to exit on a signal
+
+ findbugs reason:
+ Dm: Method invokes System.exit(...) (DM_EXIT)
+ -->
+ <Match>
+ <Class name="org.ovirt.engine.core.notifier.NotifierSignalHandler" />
+ <Method name="handle"/>
+ <Bug code="Dm"/>
+ </Match>
</FindBugsFilter>
--
To view, visit http://gerrit.ovirt.org/15273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3bd1a72e5f7b78cbea10066d9e6490bee2ade86
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
