Allon Mureinik has posted comments on this change. Change subject: core: [WIP] add memory volume to snapshot entity ......................................................................
Patch Set 10: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_03_0142_add_memory_volume_column_snapshots.sql Line 1: --Add memory volume into snapshots Line 2: SELECT fn_db_add_column('snapshots', 'memory_volume', 'character varying(255) NOT NULL DEFAULT '''''); 1. Saves space. 2. Less potential for fragmentation 3. Is consistently handled across DB vendors if (when) we ever want to switch -- To view, visit http://gerrit.ovirt.org/14053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecda4c491fe6e207386edf2a9bf2488ec81a332a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches