Arik Hadas has posted comments on this change.
Change subject: core: [WIP] add memory volume to snapshot entity
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_03_0142_add_memory_volume_column_snapshots.sql
Line 1: --Add memory volume into snapshots
Line 2: SELECT fn_db_add_column('snapshots', 'memory_volume', 'character
varying(255) NOT NULL DEFAULT ''''');
I agree, that's something that needs to be changed, but as you said - I prefer
not to do it as part of this feature
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 769: SnapshotType.REGULAR,
Line 770: disk.getDescription(),
Line 771: disk.getLastModifiedDate(),
Line 772: disk.getAppList(),
Line 773: StringUtils.EMPTY));
right, but that's a matter of taste you know.. the compiler should replace it
on compilation time as it's a constant so the imports/dependencies should not
have any effect. I prefer to use the constant so that find-all-usages can be
used if needed, and I find it more readable that way (although it's longer)
Line 774: }
Line 775: }
Line 776:
Line 777: /**
--
To view, visit http://gerrit.ovirt.org/14053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecda4c491fe6e207386edf2a9bf2488ec81a332a
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
