Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
......................................................................
Patch Set 11: (3 inline comments)
Regarding LinkedHashMap -
Maybe UI-Wise you are correct, and it will look nicer if we present in the same
order.
Ok, I support this approach.
....................................................
File
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtilsTest.java
Line 328: assertNotNull(pat);
Line 329: assertEquals("^(true|false)$", pat.pattern());
Line 330:
Line 331: // test sound properties
Line 332: devProp = utils.getDeviceProperties(Version.v3_3,
VmDeviceGeneralType.SOUND);
You can have a help method here, the code is repeating itself
Line 333: assertNotNull(devProp);
Line 334: assertEquals(1, devProp.size());
Line 335: pat = devProp.get("volume");
Line 336: assertNotNull(pat);
Line 471: map.put("hotplug", "0");
Line 472:
Line 473: String value = utils.convertProperties(Version.v3_3,
VmDeviceGeneralType.INTERFACE, map);
Line 474:
Line 475: // order of properties in string is unknown due to unknown
map key ordering
Right.
Line 476: assertTrue("speed=1024;duplex=half".equals(value) ||
"duplex=half;speed=1024".equals(value));
Line 477: }
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_de_DE.properties
Line 143: ACTION_TYPE_FAILED_DISK_LUN_HAS_NO_VALID_TYPE=Kann nicht ${action}
${type}. Die angegebene lun hat keine g\u00FCltige lun Type.
Line 144: ACTION_TYPE_FAILED_DISK_LUN_ISCSI_MISSING_CONNECTION_PARAMS=Kann
nicht ${action} ${type}. Der angegebenen lun fehlt zumindest ein
Verbindungsparameter (address/port/iqn).
Line 145: ACTION_TYPE_FAILED_MIGRATION_IN_PROGRESS=Kann nicht ${action}
${type}. VM-Migration ist im Gange
Line 146: ACTION_TYPE_FAILED_MIGRATION_TO_SAME_HOST=Kann nicht ${action}
${type}. Quelle und Ziel ist gleich.
Line 147: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_SYNTAX=Kann
nicht ${action} ${type} wenn benutzerdefinierte Eigenschaften in
ung\u00FCltigem Format sind. Bitte \u00FCberpr\u00FCfen Sie die Eingabe.
Martin, please remove the translated AppProperties files. As Alona explained
you in a difference patch, this will be handled by the translation group.
Thanks!
Line 148: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_KEYS=Kann nicht
${action} ${type} wenn einige der benutzerdefinierten Eigenschaften nicht durch
das System konfiguriert sind. Die Schl\u00FCssel sind\: ${MissingKeys}
Line 149: ACTION_TYPE_FAILED_INVALID_CUSTOM_PROPERTIES_INVALID_VALUES=Kann
nicht ${action} ${type} wenn einige der benutzerdefinierten Eigenschaften
unzul\u00E4ssige Werte haben. Die Schl\u00FCssel sind\: ${WrongValueKeys}
Line 150: ACTION_TYPE_FAILED_VDS_VM_CLUSTER=Kann nicht ${action} ${type}. Es
gibt keine verf\u00FCgbaren laufenden Hosts im Host-Cluster.
Line 151: ACTION_TYPE_FAILED_VDS_VM_MEMORY=Kann nicht ${action} ${type}. Es
gibt keine verf\u00FCgbaren laufenden Hosts mit ausreichendem Speicher im
VM-Cluster.
--
To view, visit http://gerrit.ovirt.org/14814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
