Martin Peřina has posted comments on this change. Change subject: core: Adds custom properties to VmDevice ......................................................................
Patch Set 11: Moti, thanks for detailed review, I will fix issues in the next patch set. Also I don't think it's a big problem to reimplement custom properties from String to Map<String,String> inside VmDevice. If we will use LinkedHashMap, the order of key,value entries will be consistent over time. So only one question comes to my mind: should custom properties be sorted alphabetically by key name prior to save them in the database? Or should we keep the order that comes from UI (ie. the order the user entered custom properties in)? -- To view, visit http://gerrit.ovirt.org/14814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
