Gilad Chaplik has posted comments on this change.
Change subject: userportal,webadmin: redesign of vm related dialogs
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
Line 32:
Line 33: <g:HTMLPanel>
Line 34: <g:FlowPanel ui:field="tabContainer"
addStyleNames="{style.bar}" />
Line 35: <g:FlowPanel addStyleNames="{style.contentContainer}">
Line 36: <g:SimplePanel ui:field="tabHeaderContainer"
addStyleNames="{style.header}" />
the tabs aren't influencing the header content, so shouldn't the header be
positioned above the tab container?
Line 37: <g:SimplePanel ui:field="tabContentContainer"
addStyleNames="{style.content}" />
Line 38: </g:FlowPanel>
Line 39: <div style="clear: both;" />
Line 40: </g:HTMLPanel>
--
To view, visit http://gerrit.ovirt.org/14635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icad8098e286f821da25fac22fd0a840a42f105c9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Eldan Hildesheim <i...@eldanet.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
