Liron Ar has posted comments on this change.
Change subject: core: [WIP] add memory snapshot feature support
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
Line 101: * Compatibility version to check for.
Line 102: * @return <code>true</code> if memory snapshot is supported for
the version, <code>false</code> if it's not.
Line 103: */
Line 104: public static boolean memorySnapshot(Version version) {
Line 105: return supportedInConfig(ConfigValues.MemorySnapshotEnabled,
version);
perhaps change it to MemorySnapshotSupported
Line 106: }
--
To view, visit http://gerrit.ovirt.org/14167
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69484598af0205d043b6f0438182a20adfeffff8
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
