Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: fix local state dirs ownership ......................................................................
Patch Set 1: (2 inline comments) > it should be done only if at least one file is not owned by engine. done .................................................... File packaging/setup/plugins/ovirt-engine-common/system/environment.py Line 44: ) Line 45: def _init(self): Line 46: if self.environment[osetupcons.CoreEnv.DEVELOPER_MODE]: Line 47: rootUser = engineUser = apacheUser = pwd.getpwuid(os.geteuid())[0] Line 48: engineGroup = pwd.getpwuid(os.geteuid())[4] Done Line 49: else: Line 50: rootUser = osetupcons.Defaults.DEFAULT_SYSTEM_USER_ROOT Line 51: engineUser = osetupcons.Defaults.DEFAULT_SYSTEM_USER_ENGINE Line 52: apacheUser = osetupcons.Defaults.DEFAULT_SYSTEM_USER_APACHE .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/localstate.py Line 55: self.environment[osetupcons.SystemEnv.USER_ENGINE] Line 56: ) Line 57: gid = osetuputil.getUid( Line 58: self.environment[osetupcons.SystemEnv.GROUP_ENGINE] Line 59: ) Done Line 60: for root, dirs, files in os.walk( Line 61: top=osetupcons.FileLocations.OVIRT_ENGINE_DEPLOYMENTS_DIR, Line 62: followlinks=False, Line 63: ): -- To view, visit http://gerrit.ovirt.org/15117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I180fa0b1c3ded975c052405126819d91524a829f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
