Maor Lipchuk has posted comments on this change. Change subject: core: Remove call to super CDA(2) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java Line 161 Line 162 Line 163 Line 164 Line 165 (copied from previous patch) I disagree, if someone changing something up the hierarchy he should know what he is doing and check how it reflects other commands. The same thing goes if we keep the call to the super and the same careless developer will insert a change up the hierarchy that will reflect on this command. -- To view, visit http://gerrit.ovirt.org/15089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b777f9f7c5778fd696a04350381f4587022b469 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
