[Engine-patches] Change in ovirt-engine[master]: core: Remove call to super CDA(2)

[mlipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: core: Remove call to super CDA(2)
......................................................................

core: Remove call to super CDA(2)

1) Remove call to super CDA after it was removed from
StoragePoolManagementCommandBase in the previous patch.
2) moved initialization for action type from the CDA to
setActionMessageParameters method.

Change-Id: I7b777f9f7c5778fd696a04350381f4587022b469
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/15089/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
index 4321139..97b5752 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
@@ -161,8 +161,14 @@
     }
 
     @Override
+    protected void setActionMessageParameters() {
+        super.setActionMessageParameters();
+        addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE);
+    }
+
+    @Override
     protected boolean canDoAction() {
-        boolean returnValue = super.canDoAction() && checkStoragePool();
+        boolean returnValue = checkStoragePool();
         _oldStoragePool = getStoragePoolDAO().get(getStoragePool().getId());
         if (returnValue && !StringUtils.equals(_oldStoragePool.getname(), 
getStoragePool().getname())
                 && getStoragePoolDAO().getByName(getStoragePool().getname()) 
!= null) {
@@ -207,7 +213,6 @@
         if (returnValue) {
             returnValue = 
validate(validator.isGlusterDcAndMatchingCompatiblityVersion());
         }
-        addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE);
         return returnValue;
     }
 


--
To view, visit http://gerrit.ovirt.org/15089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b777f9f7c5778fd696a04350381f4587022b469
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches