Oved Ourfali has posted comments on this change.
Change subject: foreman integration - showing foreman hosts in new host dialog
......................................................................
Patch Set 14: (2 inline comments)
New patch will follow, once I verify things.
Thank you very much for your review,
Oved
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
Line 19: }
Line 20:
Line 21: @Override
Line 22: protected void updateModelDataCenterFromVds(ArrayList<StoragePool>
dataCenters, VDS vds) {
Line 23: if (dataCenters != null && vds.getStoragePoolId() != null)
You're right. In case of edit I don't really need that.
Line 24: {
Line 25: getDataCenter().setItems(dataCenters);
Line 26:
getDataCenter().setSelectedItem(Linq.firstOrDefault(dataCenters,
Line 27: new
Linq.DataCenterPredicate(vds.getStoragePoolId())));
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
Line 301: @Path(value = "consoleAddressEnabled.entity")
Line 302: EntityModelCheckBoxEditor consoleAddressEnabled;
Line 303:
Line 304: @UiField(provided = true)
Line 305: InfoIcon providerSearchInfoIcon;
With the fix in NewHostModel it will be hidden with the panel.
Line 306:
Line 307: @UiField
Line 308: FlowPanel externalProviderPanel;
Line 309:
--
To view, visit http://gerrit.ovirt.org/14582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ea180e477a8f0714c4dc97ec55f29be515723a
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
