Yair Zaslavsky has posted comments on this change. Change subject: foreman integration - showing foreman hosts in new host dialog ......................................................................
Patch Set 10: (1 inline comment) Minor comment, Please fix, engine side looks good. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java Line 29: Line 30: private HttpClient httpClient = new HttpClient(); Line 31: Line 32: private ObjectMapper objectMapper = new ObjectMapper(); Line 33: private final String ERROR_MESSAGE = "Failed connecting to provider. "; why not private final static? fix it, I will give u +1. Line 34: private final String API_ENTRY_POINT = "/api"; Line 35: private final String HOSTS_ENTRY_POINT = API_ENTRY_POINT + "/hosts"; Line 36: private final String JSON_FORMAT = "format=json"; Line 37: private final String ALL_HOSTS_QUERY = HOSTS_ENTRY_POINT + "?" + JSON_FORMAT; -- To view, visit http://gerrit.ovirt.org/14582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ea180e477a8f0714c4dc97ec55f29be515723a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
